From 012a9a0fc736b6b727485dd7790b961bcd20245d Mon Sep 17 00:00:00 2001
From: Fioddor Superconcentrado <fioddor@gmail.com>
Date: Tue, 15 Dec 2020 20:33:25 +0100
Subject: [PATCH] networks: Prevent unintended changes to primary connection.

Helps: #1962

Shown an alarming warning in connection_show page (only) for the primary
connection. Captions 'Deactivate' and 'Delete' buttons, now explicitly
mention the primary connection and they are placed within the warning
box.

Signed-off-by: Fioddor Superconcentrado <fioddor@gmail.com>
[sunil: Primary connection is not the same as connection user is using]
[sunil: Reduce the importance of primary connection as it is just default route]
[sunil: Update primary connection message]
[sunil: Fix the use of exclamation icon for screen readers as per bootstrap]
[sunil: Don't place buttons inside the warning, as it is non-intuitive UI]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
---
 .../modules/networks/templates/connection_show.html | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/plinth/modules/networks/templates/connection_show.html b/plinth/modules/networks/templates/connection_show.html
index 77cee885a..9d6d63902 100644
--- a/plinth/modules/networks/templates/connection_show.html
+++ b/plinth/modules/networks/templates/connection_show.html
@@ -17,6 +17,19 @@
 
   <div class="row">
     <div class="col-md-8 offset-md-2">
+      {% if connection.primary %}
+        <div class="alert alert-warning" role="alert">
+          <span class="fa fa-exclamation-triangle" aria-hidden="true"></span>
+          <span class="sr-only">{% trans "Caution:" %}</span>
+          {% blocktrans trimmed %}
+            This is the primary connection that {{ box_name }} relies on for
+            Internet connectivity. Altering it may render your {{ box_name }}
+            unreachable. Ensure that you have other means to access
+            {{ box_name }} before altering this connection.
+          {% endblocktrans %}
+        </div>
+      {% endif %}
+
       <div class="btn-toolbar">
         <a href="{% url 'networks:edit' connection.uuid %}"
            class="btn btn-primary" role="button"