diff --git a/plinth/modules/upgrades/templates/upgrades.html b/plinth/modules/upgrades/templates/upgrades.html index f347d23fc..6bc6f0391 100644 --- a/plinth/modules/upgrades/templates/upgrades.html +++ b/plinth/modules/upgrades/templates/upgrades.html @@ -35,35 +35,30 @@ {% if result %} - {% if result.error %} - + {% if result.return_code %} +

+ {% trans "There was an error while upgrading." %} +

{% trans "Output from unattended-upgrades:" %}
-
{{ result.error }}
- {% endif %} - - {% if result.output %} -
-
- -
-
+ {% if result.output %} +
{{ result.output }}
+ {% endif %} + {% else %} +

+ {% trans "The operating system is up to date now.  " %} + +

-
{% trans "Output from unattended-upgrades:" %}
-
{{ result.output }}
+
{% trans "Output from unattended-upgrades:" %}
+
{{ result.output }}
- {% endif %} {% endif %} @@ -89,7 +84,7 @@ {% if running %}

- {% trans "Upgrade is running" %} + {% trans "System is being upgraded." %}

{% endif %} diff --git a/plinth/modules/upgrades/views.py b/plinth/modules/upgrades/views.py index 4d1d9bccc..6e83faf8c 100644 --- a/plinth/modules/upgrades/views.py +++ b/plinth/modules/upgrades/views.py @@ -69,10 +69,7 @@ def index(request): @package.required(['unattended-upgrades'], on_install=on_install) def upgrade(request): """Serve the upgrade page.""" - if upgrade_process: - result = _collect_upgrade_result(request) - else: - result = None + result = _collect_upgrade_result(request) return TemplateResponse(request, 'upgrades.html', {'title': _('Package Upgrades'), @@ -135,7 +132,7 @@ def _collect_upgrade_result(request): return_code = upgrade_process.poll() # Upgrade process is not complete yet - if return_code == None: + if return_code is None: return output, error = upgrade_process.communicate() @@ -144,7 +141,7 @@ def _collect_upgrade_result(request): if not return_code: messages.success(request, _('Upgrade completed.')) else: - messages.info(request, _('Upgrade failed.')) + messages.error(request, _('Upgrade failed.')) upgrade_process = None