nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-20 10:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

app: Fix a pytest warning in tests

Browse Source 
A class name that starts with 'Test' is considered for test case collection
resulting in the following warning:

plinth/tests/test_app.py:28
  /home/bunny/work/freedombox/plinth/plinth/tests/test_app.py:28: PytestWarning:
  cannot collect test class 'TestApp' because it has a __init__ constructor
  class TestApp(App):

Since this class does not contain test cases itself, rename it.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2019-10-27 12:30:52 -07:00 committed by James Valleroy
parent 121c1cf4ca
commit 030deaf4d9
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plinth/tests/test_app.py
View File

@ -25,7 +25,7 @@ import pytest
from plinth.app import App, Component, FollowerComponent, LeaderComponent from plinth.app import App, Component, FollowerComponent, LeaderComponent
class TestApp(App): class AppTest(App):
"""Sample App for testing.""" """Sample App for testing."""
app_id = 'test-app' app_id = 'test-app'
@ -38,7 +38,7 @@ class LeaderTest(FollowerComponent):
@pytest.fixture(name='app_with_components') @pytest.fixture(name='app_with_components')
def fixture_app_with_components(): def fixture_app_with_components():
"""Setup an app with some components.""" """Setup an app with some components."""
app = TestApp() app = AppTest()
app.add(FollowerComponent('test-follower-1')) app.add(FollowerComponent('test-follower-1'))
app.add(FollowerComponent('test-follower-2')) app.add(FollowerComponent('test-follower-2'))
app.add(LeaderTest('test-leader-1')) app.add(LeaderTest('test-leader-1'))
@ -54,7 +54,7 @@ def fixture_empty_apps():
def test_app_instantiation(): def test_app_instantiation():
"""Test that App is instantiated properly.""" """Test that App is instantiated properly."""
app = TestApp() app = AppTest()
assert isinstance(app.components, collections.OrderedDict) assert isinstance(app.components, collections.OrderedDict)
assert not app.components assert not app.components
assert app.app_id == 'test-app' assert app.app_id == 'test-app'
@ -64,13 +64,13 @@ def test_app_instantiation():
def test_get(): def test_get():
"""Test that an app can be correctly retrieved.""" """Test that an app can be correctly retrieved."""
app = TestApp() app = AppTest()
assert App.get(app.app_id) == app assert App.get(app.app_id) == app
def test_app_add(): def test_app_add():
"""Test adding a components to an App.""" """Test adding a components to an App."""
app = TestApp() app = AppTest()
component = Component('test-component') component = Component('test-component')
return_value = app.add(component) return_value = app.add(component)
assert len(app.components) == 1 assert len(app.components) == 1
@ -157,7 +157,7 @@ def test_app_is_enabled(app_with_components):
def test_app_is_enabled_with_no_leader_components(): def test_app_is_enabled_with_no_leader_components():
"""When there are not leader components, app.is_enabled() returns True.""" """When there are not leader components, app.is_enabled() returns True."""
app = TestApp() app = AppTest()
assert app.is_enabled() assert app.is_enabled()