From 05815bc992c949177716cacbe27b91fe9514afe3 Mon Sep 17 00:00:00 2001 From: Joseph Nuthalapati Date: Sat, 2 Jul 2022 17:53:21 +0530 Subject: [PATCH] ci: Use compatible versions of Selenium and Splinter This is a temporary fix until Splinter addresses the breaking changes in Selenium 4.3.0 Signed-off-by: Joseph Nuthalapati Reviewed-by: James Valleroy --- .ci/functional-tests.yml | 2 +- plinth/tests/functional/install.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.ci/functional-tests.yml b/.ci/functional-tests.yml index 841771cb8..3089ce1ad 100644 --- a/.ci/functional-tests.yml +++ b/.ci/functional-tests.yml @@ -34,7 +34,7 @@ - adduser tester --gecos "First Last,RoomNumber,WorkPhone,HomePhone" --disabled-password && echo "tester:password" | chpasswd script: - cp -r . /home/tester/freedombox && chown -R tester:tester /home/tester/freedombox - - sudo -u tester bash -c 'pip3 install --user splinter pytest-splinter pytest-reporter-html1' + - sudo -u tester bash -c 'pip3 install --user selenium==4.2.0 splinter==0.17.0 pytest-splinter pytest-reporter-html1' - | sudo FREEDOMBOX_URL="https://$APP_SERVER_IP" -u tester bash -c \ 'cd /home/tester/freedombox && py.test-3 -v --durations=10 --include-functional --splinter-headless --template=html1/index.html --report=functional-tests.html' diff --git a/plinth/tests/functional/install.sh b/plinth/tests/functional/install.sh index 484de4ac6..829274bfb 100755 --- a/plinth/tests/functional/install.sh +++ b/plinth/tests/functional/install.sh @@ -7,7 +7,8 @@ sudo apt-get install -yq --no-install-recommends \ python3-pytest python3-pytest-django python3-pytest-xdist \ python3-pip python3-wheel firefox-esr git smbclient -pip3 install --user splinter pytest-splinter pytest-reporter-html1 +# Use compatible versions of Splinter and Selenium +pip3 install --user selenium==4.2.0 splinter==0.17.0 pytest-splinter pytest-reporter-html1 echo "Installing geckodriver" (