nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-20 10:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

minetest: Reduce the number of configuration update messages

Browse Source 
Reduces translation burden, more consistency with other apps and allows generic
implementation in framework in the future.

Tests:

- Install and update configuration for minetest. See message 'Configuration
updated'. If configuration is not updated, 'Settings unchanged' message is
shown.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2022-02-06 15:15:45 -08:00 committed by James Valleroy
parent 3cbd8f604b
commit 09d177755d
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
plinth/modules/minetest/views.py
View File

@ -37,6 +37,7 @@ class MinetestAppView(AppView): # pylint: disable=too-many-ancestors
"""Change the configurations of Minetest service.""" """Change the configurations of Minetest service."""
data = form.cleaned_data data = form.cleaned_data
old_config = get_configuration() old_config = get_configuration()
updated = False
if old_config['max_players'] != data['max_players'] \ if old_config['max_players'] != data['max_players'] \
and data['max_players'] is not None: and data['max_players'] is not None:
@ -44,26 +45,27 @@ class MinetestAppView(AppView): # pylint: disable=too-many-ancestors
'minetest', 'minetest',
['configure', '--max_players', ['configure', '--max_players',
str(data['max_players'])]) str(data['max_players'])])
messages.success(self.request, updated = True
_('Maximum players configuration updated'))
if old_config['creative_mode'] != data['creative_mode']: if old_config['creative_mode'] != data['creative_mode']:
value = 'true' if data['creative_mode'] else 'false' value = 'true' if data['creative_mode'] else 'false'
actions.superuser_run('minetest', actions.superuser_run('minetest',
['configure', '--creative_mode', value]) ['configure', '--creative_mode', value])
messages.success(self.request, updated = True
_('Creative mode configuration updated'))
if old_config['enable_pvp'] != data['enable_pvp']: if old_config['enable_pvp'] != data['enable_pvp']:
value = 'true' if data['enable_pvp'] else 'false' value = 'true' if data['enable_pvp'] else 'false'
actions.superuser_run('minetest', actions.superuser_run('minetest',
['configure', '--enable_pvp', value]) ['configure', '--enable_pvp', value])
messages.success(self.request, _('PVP configuration updated')) updated = True
if old_config['enable_damage'] != data['enable_damage']: if old_config['enable_damage'] != data['enable_damage']:
value = 'true' if data['enable_damage'] else 'false' value = 'true' if data['enable_damage'] else 'false'
actions.superuser_run('minetest', actions.superuser_run('minetest',
['configure', '--enable_damage', value]) ['configure', '--enable_damage', value])
messages.success(self.request, _('Damage configuration updated')) updated = True
if updated:
messages.success(self.request, _('Configuration updated'))
return super().form_valid(form) return super().form_valid(form)