From 0d0eb4472da186d105198daa74ec9335b0cd0a19 Mon Sep 17 00:00:00 2001 From: Veiko Aasa Date: Thu, 18 Apr 2024 12:39:18 +0300 Subject: [PATCH] minidlna: Explicitly include ssdp service to firewall configuration It helps showing ssdp protocol ports in minidlna diagnostics. Also avoid overwrite imported name 'firewall'. Tested that ssdp port 1900 is shown in the minidlna diagnostics page. Signed-off-by: Veiko Aasa Reviewed-by: Sunil Mohan Adapa --- plinth/modules/minidlna/__init__.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/plinth/modules/minidlna/__init__.py b/plinth/modules/minidlna/__init__.py index 11291ad4d..9f6dfcd73 100644 --- a/plinth/modules/minidlna/__init__.py +++ b/plinth/modules/minidlna/__init__.py @@ -79,9 +79,10 @@ class MiniDLNAApp(app_module.App): ['/etc/apache2/conf-available/minidlna-freedombox.conf']) self.add(dropin_configs) - firewall = Firewall('firewall-minidlna', info.name, ports=['minidlna'], - is_external=False) - self.add(firewall) + firewall_minidlna = Firewall('firewall-minidlna', info.name, + ports=['minidlna', + 'ssdp'], is_external=False) + self.add(firewall_minidlna) webserver = Webserver('webserver-minidlna', 'minidlna-freedombox', urls=['https://{host}/_minidlna/'])