From 11aa36f6cafb96281487a4fbcbe865ac7ec50edc Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Sat, 14 Dec 2024 18:02:52 -0800
Subject: [PATCH] d/control: Drop unnecessary recommendations

- These tools are not strictly needed for FreedomBox operation in anyway.

- Slightly Reduce the size of the built images.

- Some of these tools are outdated or not typically used on a modern GNU/Linux
system and make FreedomBox seem less shiny.

- Originally thought of splitting them into a separate metapackage but it does
not seem worth it.

- killall from psmisc is used in the Makefile, it is kept for now.

- FreedomBox already has many dependency and so it is now important to start
paying attention to unnecessary ones.

Tests:

- For each binary executable provided in each of the packages, verify that it
not being used in our code anywhere.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
---
 debian/control | 32 +-------------------------------
 1 file changed, 1 insertion(+), 31 deletions(-)

diff --git a/debian/control b/debian/control
index 822900033..34e1d8928 100644
--- a/debian/control
+++ b/debian/control
@@ -126,29 +126,11 @@ Depends:
 # Ensure fuse gets replaced by fuse3 on upgrades from buster s.t. sshfs can be installed.
  fuse3,
 Recommends:
-# Priority: standard
- bzip2,
-# Provides brctl for controlling bridges
- bridge-utils,
-# Read, write to char devices
- devio,
-# Create, repair DOS filesystems
- dosfstools,
-# Priority: standard
- file,
 # Wifi firmware
  firmware-ath9k-htc,
 # FreedomBox documentation
  freedombox-doc-en,
  freedombox-doc-es,
-# Monitor system resources
- htop,
-# Monitor network traffic statistics
- iftop,
-# Basic network utitlity ping
- iputils-ping,
-# Manage wireless devices
- iw,
 # Resolve .local address using mDNS
  libnss-mdns,
 # Resolve current hostname without /etc/hosts
@@ -161,22 +143,10 @@ Recommends:
  locales-all,
 # Priority: standard
  openssh-client,
-# Priority: standard
- pciutils,
 # Used by unattended-upgrades to check if running on AC power
  powermgmt-base,
-# fuser, pstree and other utilities
+# fuser, killall, pstree and other utilities
  psmisc,
-# Tool to kill WLAN, Bluetooth and moble broadband
- rfkill,
-# Monitor network traffic
- tcpdump,
-# Basic editor, VIM style
- vim-tiny,
-# Priority: standard
- whois,
-# Basic editor, Emacs style
- zile,
 Description: easy to manage, privacy oriented home server
  FreedomBox is designed to be your own inexpensive server at home. It runs free
  software and offers an increasing number of services ranging from a calendar or