nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: app: Fix an incorrect HTML tag nesting

Browse Source 
- <div> is not allowed inside a <p> tag. Browsers will close and reopen <p> if
one tries to place a <div> inside a <p>. Avoid this.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
This commit is contained in:
Sunil Mohan Adapa 2024-11-16 08:33:42 -08:00 committed by Veiko Aasa
parent 7602cf6172
commit 11cb883518
No known key found for this signature in database
GPG Key ID: 478539CAE680674E
1 changed files with 33 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plinth/templates/port-forwarding-info.html
View File

@ -7,28 +7,33 @@
{% if port_forwarding_info.ports %}
<h3>{% trans "Port Forwarding" %}</h3>
<p>
{% url 'networks:index' as networks_url %}
{% if port_forwarding_info.network_topology_type != "to_router" %}
<p>
{% blocktrans trimmed %}
Your FreedomBox is <a href="{{ networks_url }}">not behind a router</a>.
No action is necessary.
{% endblocktrans %}
<span class="fa fa-check" aria-hidden="true"></span>
</p>
{% elif port_forwarding_info.router_configuration_type == 'dmz' %}
<p>
{% blocktrans trimmed %}
Your FreedomBox is <a href="{{ networks_url }}"> behind a router</a> and
you are using the DMZ feature to forward all ports. No further router
configuration is necessary.
{% endblocktrans %}
<span class="fa fa-check" aria-hidden="true"></span>
</p>
{% else %}
<p>
{% blocktrans trimmed %}
Your FreedomBox is <a href="{{ networks_url }}">behind a router</a> and
you are not using the DMZ feature. You will need to set up port
forwarding on your router. You should forward the following ports for
{{ service_name }}:
{% endblocktrans %}
</p>
<div class="table-responsive table-port-forwarding-info">
<table class="table">
@ -53,6 +58,5 @@
</table>
</div>
{% endif %}
</p>
{% endif %}