nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-08-26 12:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions: Fix log message when action return can't be decoded

Browse Source 
return_value is not available during exception handling.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2024-03-01 20:09:25 -08:00 committed by James Valleroy
parent 15b537ccb7
commit 1274ffdf87
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plinth/actions.py
View File

@ -134,9 +134,8 @@ def _wait_for_return(module_name, action_name, args, kwargs, log_error, proc,
try: try:
return_value = json.loads(b''.join(buffers)) return_value = json.loads(b''.join(buffers))
except json.JSONDecodeError: except json.JSONDecodeError:
logger.error( logger.error('Error decoding action return value %s..%s(*%s, **%s)',
'Error decoding action return value %s..%s(*%s, **%s): %s', module_name, action_name, args, kwargs)
module_name, action_name, args, kwargs, return_value)
raise raise
if return_value['result'] == 'success': if return_value['result'] == 'success':