mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
setup: Log full exception traceback when setup fails
- When an error occurs during setup thread execution and the error is not due a failed privileged action, we are left with very little information about what went run. On the other than when a privileged action fails, we will be logging the exception twice. But this is okay. Tests: - Increment the setup version of one of installed apps and raise an exception in setup() method. Notice that exception traceback in the logged message. - Increment the setup version of one of installed apps and raise an exception in setup's privileged action. Notice that exception traceback in the logged message twice. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Veiko Aasa <veiko17@disroot.org>
This commit is contained in:
parent
a43082308d
commit
2fbaea191f
@ -350,7 +350,7 @@ def run_setup_on_apps(app_ids, allow_install=True):
|
||||
else:
|
||||
setup_apps(app_ids, allow_install=allow_install)
|
||||
except Exception as exception:
|
||||
logger.error('Error running setup - %s', exception)
|
||||
logger.exception('Error running setup - %s', exception)
|
||||
raise
|
||||
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user