From 30aae90030911eb430f9e087320fb3a06c84793c Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Fri, 18 Dec 2020 13:35:37 -0800
Subject: [PATCH] help: Show version information as an alert

- Move the message to the top as it is important and a likely reason to visit
the about page.

- Turn it into an alert so that it stands out from the rest of the text. Success
when up-to-date, warning otherwise.

- Remove custom inline styling.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
---
 plinth/modules/help/templates/help_about.html | 35 ++++++++++---------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/plinth/modules/help/templates/help_about.html b/plinth/modules/help/templates/help_about.html
index af0894daa..4dddbcfb4 100644
--- a/plinth/modules/help/templates/help_about.html
+++ b/plinth/modules/help/templates/help_about.html
@@ -13,6 +13,24 @@
          class="main-graphic" />
   </p>
 
+  <div class="alert {% if new_version %}alert-warning{% else %}alert-success{% endif %}">
+    {% blocktrans trimmed %}
+      You are running {{ os_release }} and {{ box_name }} version {{ version }}.
+    {% endblocktrans %}
+
+    {% if new_version %}
+      {% url 'upgrades:index' as upgrades_url %}
+      {% blocktrans trimmed %}
+        There is a new {{ box_name }} version
+        <a href="{{ upgrades_url }}">available</a>.
+      {% endblocktrans %}
+    {% else %}
+      {% blocktrans trimmed %}
+        {{ box_name }} is up to date.
+      {% endblocktrans %}
+    {% endif %}
+  </div>
+
   <p>
     {% blocktrans trimmed %}
       {{ box_name }} is a community project to develop, design and
@@ -59,21 +77,4 @@
         href="https://wiki.debian.org/FreedomBox"
         target="_blank">{% trans "Learn more" %}</a></p>
 
-  <p style='margin-top:1.875rem'>
-    {% blocktrans trimmed %}
-      You are running {{ os_release }} and {{ box_name }} version {{ version }}.
-    {% endblocktrans %}
-
-    {% if new_version %}
-      {% url 'upgrades:index' as upgrades_url %}
-      {% blocktrans trimmed %}
-        There is a new {{ box_name }} version
-        <a href="{{ upgrades_url }}">available</a>.
-      {% endblocktrans %}
-    {% else %}
-      {% blocktrans trimmed %}
-        {{ box_name }} is up to date.
-      {% endblocktrans %}
-    {% endif %}
-  </p>
 {% endblock %}