nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-08-19 12:36:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: functional: Wait for uninstall page load before uninstalling

Browse Source 
- Many functional test failures in the Gitlab CI pipeline show that uninstall
form was attempted to submitted while still in the app page. After clicking on
the uninstall menu item, we are not waiting for the page to load fully. Fix this
by waiting for page load. This change is expected to fix most of the functional
tests failures in the pipeline.

Tests:

- Ran bepasty functional tests.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
This commit is contained in:
Sunil Mohan Adapa 2024-11-06 11:12:15 -08:00 committed by Veiko Aasa
parent 85cf5a16c8
commit 3807ee4c54
No known key found for this signature in database
GPG Key ID: 478539CAE680674E
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plinth/tests/functional/__init__.py
View File

@ -424,7 +424,9 @@ def uninstall(browser, app_name):
if not uninstall_item:
pytest.skip('App cannot be uninstalled')
uninstall_page_url = uninstall_item[0]['href']
uninstall_item[0].click()
wait_for_page_update(browser, expected_url=uninstall_page_url)
submit(browser, form_class='form-uninstall')
while True: