tor: tests: Convert to pytest style tests from class based tests

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2024-02-15 10:33:45 -08:00 committed by James Valleroy
parent 37b9e21e30
commit 3aae4b39d6
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808

View File

@ -11,72 +11,64 @@ from django.core.exceptions import ValidationError
from plinth.modules.tor import forms, utils
class TestTor:
"""Test cases for testing the Tor module."""
@patch('plinth.app.App.get')
@pytest.mark.usefixtures('needs_root', 'load_cfg')
def test_get_status(_app_get):
"""Test that get_status does not raise any unhandled exceptions.
@staticmethod
@patch('plinth.app.App.get')
@pytest.mark.usefixtures('needs_root', 'load_cfg')
def test_get_status(_app_get):
"""Test that get_status does not raise any unhandled exceptions.
This should work regardless of whether tor is installed, or
/etc/tor/instances/plinth/torrc exists.
"""
utils.get_status()
This should work regardless of whether tor is installed, or
/etc/tor/instances/plinth/torrc exists.
"""
utils.get_status()
class TestTorForm:
"""Test whether Tor configration form works."""
def test_bridge_validator():
"""Test upstream bridges' form field validator."""
validator = forms.bridges_validator
@staticmethod
def test_bridge_validator():
"""Test upstream bridges' form field validator."""
validator = forms.bridges_validator
# Just IP:port
validator('73.237.165.184:9001')
validator('73.237.165.184')
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]:443')
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]')
# Just IP:port
validator('73.237.165.184:9001')
validator('73.237.165.184')
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]:443')
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]')
# With fingerprint
validator('73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8')
# With fingerprint
validator('73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8')
# With transport type
validator('obfs4 73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8')
# With transport type
validator('obfs4 73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8')
# With transport type and extra options
validator('obfs4 10.1.1.1:30000 '
'0123456789ABCDEF0123456789ABCDEF01234567 '
'cert=A/b+1 iat-mode=0')
# With transport type and extra options
validator('obfs4 10.1.1.1:30000 '
'0123456789ABCDEF0123456789ABCDEF01234567 '
'cert=A/b+1 iat-mode=0')
# Leading, trailing spaces and empty lines
validator('\n'
' \n'
'73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8'
' \n'
'73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8'
' \n'
'\n')
# Leading, trailing spaces and empty lines
validator('\n'
' \n'
'73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8'
' \n'
'73.237.165.184:9001 '
'0D04F10F497E68D2AF32375BB763EC3458A908C8'
' \n'
'\n')
# Invalid number for parts
with pytest.raises(ValidationError):
validator(' ')
# Invalid number for parts
with pytest.raises(ValidationError):
validator(' ')
# Invalid IP address/port
with pytest.raises(ValidationError):
validator('73.237.165.384:9001')
# Invalid IP address/port
with pytest.raises(ValidationError):
validator('73.237.165.384:9001')
with pytest.raises(ValidationError):
validator('73.237.165.184:90001')
with pytest.raises(ValidationError):
validator('73.237.165.184:90001')
with pytest.raises(ValidationError):
validator('[a2001:db8:85a3:8d3:1319:8a2e:370:7348]:443')
with pytest.raises(ValidationError):
validator('[a2001:db8:85a3:8d3:1319:8a2e:370:7348]:443')
with pytest.raises(ValidationError):
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]:90443')
with pytest.raises(ValidationError):
validator('[2001:db8:85a3:8d3:1319:8a2e:370:7348]:90443')