From 53c5cab91c4e103ccc1d335d81ec3abf25c8b499 Mon Sep 17 00:00:00 2001
From: Joseph Nuthalapati <njoseph@riseup.net>
Date: Fri, 6 Sep 2019 21:51:04 +0530
Subject: [PATCH] manual: Move PDF download link to HTML manual page

- Remove "Download Manual" card
- Create link to download manual in the header of the HTML manual

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
[sunil@medhas.org Remove hard-coded URL for manual download]
[sunil@medhas.org Fix CSS indentation]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
---
 plinth/modules/help/help.py                    |  5 -----
 plinth/modules/help/templates/help_index.html  |  4 ----
 plinth/modules/help/templates/help_manual.html | 15 ++++++++++++++-
 3 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/plinth/modules/help/help.py b/plinth/modules/help/help.py
index 7b763202c..c9e20c452 100644
--- a/plinth/modules/help/help.py
+++ b/plinth/modules/help/help.py
@@ -52,11 +52,6 @@ class HelpApp(app_module.App):
                               None, 'fa-info-circle', 'help:manual',
                               parent_url_name='help:index', order=10)
         self.add(menu_item)
-        menu_item = menu.Menu('menu-help-download-manual',
-                              ugettext_lazy('Download Manual'), None,
-                              'fa-download', 'help:download-manual',
-                              parent_url_name='help:index', order=15)
-        self.add(menu_item)
         menu_item = menu.Menu('menu-help-support',
                               ugettext_lazy('Get Support'), None,
                               'fa-life-ring', 'help:support',
diff --git a/plinth/modules/help/templates/help_index.html b/plinth/modules/help/templates/help_index.html
index 761bb5ebc..35178f20b 100644
--- a/plinth/modules/help/templates/help_index.html
+++ b/plinth/modules/help/templates/help_index.html
@@ -94,7 +94,3 @@
   {% endif %}
 
 {% endblock %}
-
-{% block page_js %}
-  <script type="text/javascript" src="{% static 'help/help.js' %}"></script>
-{% endblock %}
diff --git a/plinth/modules/help/templates/help_manual.html b/plinth/modules/help/templates/help_manual.html
index ee9ae0af9..951d64340 100644
--- a/plinth/modules/help/templates/help_manual.html
+++ b/plinth/modules/help/templates/help_manual.html
@@ -19,15 +19,28 @@
 {% endcomment %}
 
 {% load i18n %}
+{% load static %}
 
 {% block page_head %}
   <style type="text/css">
     dd {
-      margin-left: 30px;
+        margin-left: 30px;
+    }
+    .pdf {
+        float: right;
+        margin: 4rem;
     }
   </style>
 {% endblock %}
 
 {% block content %}
+  <a href="{% url 'help:download-manual' %}"
+     title="{% trans 'Download as PDF' %}">
+    <span class="fa fa-file-pdf-o pdf"></span>
+  </a>
   {{ content|safe }}
 {% endblock %}
+
+{% block page_js %}
+  <script type="text/javascript" src="{% static 'help/help.js' %}"></script>
+{% endblock %}