From 478ec3b1d3f19dcdd27c68dea20c87405947caa7 Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa Date: Tue, 6 Jun 2023 16:03:29 -0700 Subject: [PATCH] gitweb: Fix issue with service startup when gitweb is not enabled When gitweb is installed and not enabled without any public repos, the post_inst() method tries to enable gitweb-freedombox-auth.conf apache2 configuration. Due to new approach of symlinking configuration files only when needed, the file is not found and startup of freedombox service fails. Fix it by making sure that gitweb auth configuration is only enabled when app itself is enabled. Signed-off-by: Sunil Mohan Adapa Reviewed-by: Veiko Aasa --- plinth/modules/gitweb/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plinth/modules/gitweb/__init__.py b/plinth/modules/gitweb/__init__.py index 63cdf13f7..95f826bed 100644 --- a/plinth/modules/gitweb/__init__.py +++ b/plinth/modules/gitweb/__init__.py @@ -98,7 +98,7 @@ class GitwebApp(app_module.App): def post_init(self): """Perform post initialization operations.""" - if not self.needs_setup(): + if not self.needs_setup() and self.is_enabled(): self.update_service_access() def set_shortcut_login_required(self, login_required):