From 49acfa5ad1f7538c5cd9c5381fb8eb7a855e2ae3 Mon Sep 17 00:00:00 2001
From: James Valleroy <jvalleroy@mailbox.org>
Date: Thu, 27 Dec 2018 22:12:40 -0500
Subject: [PATCH] radicale: Add support for radicale 2.x

- Remove obsolete base_prefix and well-known configs.
- Use http_x_remote_user auth type.
- Rewrite /radicale to /radicale/.
- Add ProxyPassReverse.
- Set X-Script-Name and X-Remote-User request headers.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
---
 actions/radicale                              | 19 +++++++++++--------
 .../conf-available/radicale-plinth.conf       | 13 ++++++++++++-
 2 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/actions/radicale b/actions/radicale
index 01bf2f31f..85d503e55 100755
--- a/actions/radicale
+++ b/actions/radicale
@@ -29,7 +29,7 @@ from plinth import action_utils
 
 CONFIG_FILE = '/etc/radicale/config'
 DEFAULT_FILE = '/etc/default/radicale'
-DEFAULT_FILE_DEPRECATED_VERSION = LV('2.1.10')
+VERSION_2 = LV('2')
 
 
 def parse_arguments():
@@ -57,18 +57,21 @@ def subcommand_setup(_):
 
     aug = load_augeas()
 
-    if current_version and current_version < DEFAULT_FILE_DEPRECATED_VERSION:
+    if current_version and current_version < VERSION_2:
         aug.set('/files' + DEFAULT_FILE + '/ENABLE_RADICALE', 'yes')
 
     aug.set('/files' + CONFIG_FILE + '/server/hosts',
             '127.0.0.1:5232, [::1]:5232')
-    aug.set('/files' + CONFIG_FILE + '/server/base_prefix', '/radicale/')
-    aug.set('/files' + CONFIG_FILE + '/well-known/caldav',
-            '/radicale/%(user)s/caldav/')
-    aug.set('/files' + CONFIG_FILE + '/well-known/carddav',
-            '/radicale/%(user)s/carddav/')
-    aug.set('/files' + CONFIG_FILE + '/auth/type', 'remote_user')
     aug.set('/files' + CONFIG_FILE + '/rights/type', 'owner_only')
+    if current_version and current_version < VERSION_2:
+        aug.set('/files' + CONFIG_FILE + '/server/base_prefix', '/radicale/')
+        aug.set('/files' + CONFIG_FILE + '/well-known/caldav',
+                '/radicale/%(user)s/caldav/')
+        aug.set('/files' + CONFIG_FILE + '/well-known/carddav',
+                '/radicale/%(user)s/carddav/')
+        aug.set('/files' + CONFIG_FILE + '/auth/type', 'remote_user')
+    else:
+        aug.set('/files' + CONFIG_FILE + '/auth/type', 'http_x_remote_user')
 
     aug.save()
 
diff --git a/data/etc/apache2/conf-available/radicale-plinth.conf b/data/etc/apache2/conf-available/radicale-plinth.conf
index ed6ba9f59..fe4bbaad9 100644
--- a/data/etc/apache2/conf-available/radicale-plinth.conf
+++ b/data/etc/apache2/conf-available/radicale-plinth.conf
@@ -6,8 +6,19 @@ Redirect 301 /.well-known/carddav /radicale/.well-known/carddav
 Redirect 301 /.well-known/caldav /radicale/.well-known/caldav
 
 <Location /radicale>
-    ProxyPass http://localhost:5232
+    <IfModule mod_rewrite.c>
+        RewriteEngine On
+        RewriteCond %{REQUEST_URI} ^/radicale$
+        RewriteRule .* /radicale/ [R=301,L]
+    </IfModule>
+</Location>
 
+<Location /radicale/>
     Include includes/freedombox-auth-ldap.conf
     Require valid-user
+
+    ProxyPass        http://localhost:5232/
+    ProxyPassReverse http://localhost:5232/
+    RequestHeader    set X-Script-Name /radicale/
+    RequestHeader    set X-Remote-User %{REMOTE_USER}s
 </Location>