From 4b9b683a16cd4be4a04dd0378fbb40f048caec00 Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Thu, 17 Dec 2020 16:48:54 -0800
Subject: [PATCH] firewall: Split CSS styling into separate file

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
---
 plinth/modules/firewall/static/firewall.css   | 28 +++++++++++++++++++
 .../modules/firewall/templates/firewall.html  | 28 +++----------------
 2 files changed, 32 insertions(+), 24 deletions(-)
 create mode 100644 plinth/modules/firewall/static/firewall.css

diff --git a/plinth/modules/firewall/static/firewall.css b/plinth/modules/firewall/static/firewall.css
new file mode 100644
index 000000000..c67e29634
--- /dev/null
+++ b/plinth/modules/firewall/static/firewall.css
@@ -0,0 +1,28 @@
+/*
+# SPDX-License-Identifier: AGPL-3.0-or-later
+*/
+
+a.dropdown-toggle {
+    color: black;
+}
+
+a.dropdown-toggle:hover {
+    text-decoration: none;
+}
+
+td.service {
+    padding-left: 2rem;
+}
+
+.service-name {
+    font-style: italic;
+}
+
+.app-status,
+.service-status {
+    width: 11rem;
+}
+
+tr.collapse {
+    background-color: #f9f9f9;
+}
diff --git a/plinth/modules/firewall/templates/firewall.html b/plinth/modules/firewall/templates/firewall.html
index d97933749..e87d4618c 100644
--- a/plinth/modules/firewall/templates/firewall.html
+++ b/plinth/modules/firewall/templates/firewall.html
@@ -4,30 +4,11 @@
 {% endcomment %}
 
 {% load i18n %}
+{% load static %}
 
 {% block page_head %}
-  <style type="text/css">
-   a.dropdown-toggle {
-       color: black;
-   }
-
-   a.dropdown-toggle:hover {
-       text-decoration: none;
-   }
-
-   td.service {
-       padding-left: 2rem;
-   }
-
-   .service-name {
-       font-style: italic;
-   }
-
-   .app-status,
-   .service-status {
-       width: 11rem;
-   }
-  </style>
+  <link type="text/css" rel="stylesheet"
+        href="{% static 'firewall/firewall.css' %}"/>
 {% endblock %}
 
 {% block configuration %}
@@ -78,8 +59,7 @@
                 </td>
               </tr>
               {% for port in component.ports_details %}
-                <tr class="collapse {{component.component_id}}"
-                    style="background-color: #f9f9f9" >
+                <tr class="collapse {{component.component_id}}">
                   <td class='service'>
                     <span class="service-name">{{ port.name }}</span>:
                     {% for port_number, protocol in port.details %}