From 4cfc2fb4f2823e86ece0ef07bb9c89699724dfda Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa Date: Sun, 2 Apr 2023 14:37:06 +0530 Subject: [PATCH] tests: functional: Make install script work for Bullseye - Pip option --break-system-packages is available only from Bookworm. - Remove --user to that the script works can be used broadly. Tests: - On a fresh stable container, running functional tests works. Without the patch, it fails. Signed-off-by: Sunil Mohan Adapa Reviewed-by: James Valleroy --- plinth/tests/functional/install.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plinth/tests/functional/install.sh b/plinth/tests/functional/install.sh index 4ad8ee8b4..ff719feb5 100755 --- a/plinth/tests/functional/install.sh +++ b/plinth/tests/functional/install.sh @@ -8,7 +8,10 @@ sudo apt-get install -yq --no-install-recommends \ python3-pip python3-wheel firefox-esr git smbclient # Use compatible versions of Splinter and Selenium -pip3 install --user --break-system-packages selenium==4.2.0 splinter==0.17.0 pytest-splinter pytest-reporter-html1 +PIP_VERSION=$(dpkg-query -W -f '${Version}' python3-pip) +PIP_OPTIONS= +dpkg --compare-versions 23 \<= $PIP_VERSION && PIP_OPTIONS=--break-system-packages +pip3 install $PIP_OPTIONS selenium==4.2.0 splinter==0.17.0 pytest-splinter pytest-reporter-html1 echo "Installing geckodriver" (