nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-28 08:03:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

firewall: List a service only if relevant

Browse Source 
If a service does not have corresponding firewall ports, don't list it
on firewall page.  Add a simple if condition in the template.
This commit is contained in:
Sunil Mohan Adapa 2016-06-03 18:10:52 +05:30 committed by James Valleroy
parent 6d08468933
commit 4fe0067f01
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 28 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
plinth/modules/firewall/templates/firewall.html
View File

@ -47,40 +47,42 @@
</thead>
<tbody>
<tr>
<td><strong>{{ service.name }}</strong></td>
<td>
{% if service.is_enabled %}
<span class='label label-success'>
{% trans "Enabled" %}</span>
{% else %}
<span class='label label-warning'>
{% trans "Disabled" %}</span>
{% endif %}
</td>
</tr>
{% for port in service.ports %}
{% for service in services|dictsort:"name" %}
{% if service.ports %}
<tr>
<td class='cell-indented'><em>{{ port }}</em></td>
<td><strong>{{ service.name }}</strong></td>
<td>
{% if port in internal_enabled_services and port in external_enabled_services %}
{% if service.is_enabled %}
<span class='label label-success'>
{% trans "Permitted" %}</span>
{% elif port in internal_enabled_services %}
<span class='label label-warning'>
{% trans "Permitted (internal only)" %}</span>
{% elif port in external_enabled_services %}
<span class='label label-warning'>
{% trans "Permitted (external only)" %}</span>
{% trans "Enabled" %}</span>
{% else %}
<span class='label label-danger'>
{% trans "Blocked" %}</span>
<span class='label label-warning'>
{% trans "Disabled" %}</span>
{% endif %}
</td>
</tr>
{% endfor %}
{% for port in service.ports %}
<tr>
<td class='cell-indented'><em>{{ port }}</em></td>
<td>
{% if port in internal_enabled_services and port in external_enabled_services %}
<span class='label label-success'>
{% trans "Permitted" %}</span>
{% elif port in internal_enabled_services %}
<span class='label label-warning'>
{% trans "Permitted (internal only)" %}</span>
{% elif port in external_enabled_services %}
<span class='label label-warning'>
{% trans "Permitted (external only)" %}</span>
{% else %}
<span class='label label-danger'>
{% trans "Blocked" %}</span>
{% endif %}
</td>
</tr>
{% endfor %}
{% endif %}
{% endfor %}
</tbody>
</table>