From 526c5354aa83367f353dbe8da4c59ab46eaccf2e Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Fri, 27 Dec 2024 20:30:52 -0800
Subject: [PATCH] ui: Don't show breadcrumbs in login and first wizard pages

- It was never intended that breadcrumbs be shown in these pages.

Tests:

- When running first wizard, the busy page, the welcome page, user account
create page, and the next steps page are all shown without breadcrumbs. Same for
login page.

- Other pages which had breadcrumbs earlier continue to show them, that is, app
pages, system pages, help pages, and pages under those.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
---
 plinth/modules/first_boot/templates/base_firstboot.html     | 3 +++
 plinth/modules/first_boot/templates/firstboot_complete.html | 3 +++
 plinth/modules/sso/templates/login.html                     | 3 +++
 plinth/templates/base.html                                  | 4 +++-
 4 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/plinth/modules/first_boot/templates/base_firstboot.html b/plinth/modules/first_boot/templates/base_firstboot.html
index 7efe77fd6..9c3edede9 100644
--- a/plinth/modules/first_boot/templates/base_firstboot.html
+++ b/plinth/modules/first_boot/templates/base_firstboot.html
@@ -15,6 +15,9 @@ no-brand
 {% block notifications_dropdown %}
 {% endblock %}
 
+{% block breadcrumbs %}
+{% endblock %}
+
 {% block mainmenu_toggler %}
   {% if user.is_authenticated %}
     {{ block.super }}
diff --git a/plinth/modules/first_boot/templates/firstboot_complete.html b/plinth/modules/first_boot/templates/firstboot_complete.html
index b931395dc..c05747a51 100644
--- a/plinth/modules/first_boot/templates/firstboot_complete.html
+++ b/plinth/modules/first_boot/templates/firstboot_complete.html
@@ -6,6 +6,9 @@
 {% load bootstrap %}
 {% load i18n %}
 
+{% block breadcrumbs %}
+{% endblock %}
+
 {% block content %}
 
   <h2>{% trans "Setup Complete! Next Steps:" %}</h2>
diff --git a/plinth/modules/sso/templates/login.html b/plinth/modules/sso/templates/login.html
index 0b9938dc7..e1774b884 100644
--- a/plinth/modules/sso/templates/login.html
+++ b/plinth/modules/sso/templates/login.html
@@ -6,6 +6,9 @@
 {% load bootstrap %}
 {% load i18n %}
 
+{% block breadcrumbs %}
+{% endblock %}
+
 {% block content %}
 
   <form class="form form-login" method="post">
diff --git a/plinth/templates/base.html b/plinth/templates/base.html
index c57ab5faa..4d19a4f3f 100644
--- a/plinth/templates/base.html
+++ b/plinth/templates/base.html
@@ -252,7 +252,9 @@
         {% block content_row %}
             {% include 'messages.html' %}
 
-            {% include 'breadcrumbs.html' %}
+            {% block breadcrumbs %}
+              {% include 'breadcrumbs.html' %}
+            {% endblock %}
 
             {% block content %}
               {# main content goes here #}