nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-09-19 04:59:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dont use exec() in router module

Browse Source
This commit is contained in:
Sunil Mohan Adapa 2014-04-10 10:26:52 +05:30
parent 2d39638020
commit 5a5ff04f8e
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/installed/router/router.py
View File

@ -128,14 +128,13 @@ class wan(FormPlugin, PagePlugin):
return '' return ''
store = filedict_con(cfg.store_file, 'router') store = filedict_con(cfg.store_file, 'router')
defaults = {'connect_type': "'DHCP'", defaults = {'connect_type': 'DHCP'}
} for key, value in defaults.items():
for k,c in defaults.items(): if not key in kwargs:
if not k in kwargs:
try: try:
kwargs[k] = store[k] kwargs[key] = store[key]
except KeyError: except KeyError:
exec("if not '%(k)s' in kwargs: store['%(k)s'] = kwargs['%(k)s'] = %(c)s" % {'k':k, 'c':c}) store[key] = kwargs[key] = value
form = Form(title="WAN Connection", form = Form(title="WAN Connection",
action=cfg.server_dir + "/router/setup/wan/index", action=cfg.server_dir + "/router/setup/wan/index",