From 5f434a1ac55c020df209d3cd18267f0b14280cf0 Mon Sep 17 00:00:00 2001
From: Joseph Nuthalapati <njoseph@thoughtworks.com>
Date: Tue, 19 Mar 2019 19:09:12 +0530
Subject: [PATCH] clients: Open web app in a new browser tab

The "Launch" button with its fa-external-link icon gives the impression that it
would open the web app in a new browser tab but behaves counter-intuitively by
opening it in the same tab. This commit makes the button open the link to the
web app in a new tab.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
---
 plinth/templates/clients.html | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/plinth/templates/clients.html b/plinth/templates/clients.html
index 98296fb84..15c37a581 100644
--- a/plinth/templates/clients.html
+++ b/plinth/templates/clients.html
@@ -43,10 +43,11 @@
             {% if platform.type == 'web' %}
               <td>{{ client.name }}</td>
               <td>
-                <a class="btn btn-success" role="button"
-                {% if not enabled %} disabled="disabled"
-                {% else %} href="{{ platform.url }}"
-                {% endif %}>
+                <a target="_blank" rel="noopener noreferrer"
+                  class="btn btn-success" role="button"
+                  {% if not enabled %} disabled="disabled"
+                  {% else %} href="{{ platform.url }}"
+                  {% endif %}>
                   {% trans "Launch" %}
                   <span class="fa fa-external-link"></span>
                 </a>