nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-20 10:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: Show better error message

Browse Source 
Tests:

- In a VM, mount a loopback disk. Insert an error in ejected code and notice
that HTML message is shown properly during eject operation.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2024-03-18 14:41:36 -07:00 committed by James Valleroy
parent 598d7570ff
commit 64d754701f
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plinth/modules/storage/views.py
View File

@ -14,7 +14,7 @@ from django.views.decorators.http import require_POST
from plinth import views from plinth import views
from plinth.modules import storage from plinth.modules import storage
from . import get_error_message, privileged from . import privileged
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -90,12 +90,6 @@ def eject(request, device_path):
else: else:
messages.success(request, _('Device can be safely unplugged.')) messages.success(request, _('Device can be safely unplugged.'))
except Exception as exception: except Exception as exception:
message = get_error_message(exception.args[-2].decode()) # stdout views.messages_error(request, _('Error ejecting device.'), exception)
logger.error('Error ejecting device - %s', message)
messages.error(
request,
_('Error ejecting device: {error_message}').format(
error_message=message))
return redirect(reverse('storage:index')) return redirect(reverse('storage:index'))