nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-20 10:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

help: tests: Fix about page test by mocking version calls

Browse Source 
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
Sunil Mohan Adapa 2022-08-01 15:50:14 -07:00
parent 9647b00278
commit 6db1029d27
No known key found for this signature in database
GPG Key ID: 43EA1CFF0AA7C5F2
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plinth/modules/help/tests/test_views.py
View File

@ -87,10 +87,12 @@ def test_contribute_page(requests_get, decompress, apt_cache, rf):
response.context_data['help'])
def test_about(rf):
@patch('plinth.modules.upgrades.views.is_newer_version_available')
@patch('plinth.modules.upgrades.views.get_os_release')
def test_about(_get_os_release, _is_newer_version_available, rf):
"""Test some expected items in about view."""
manual_url = urls.reverse('help:manual')
response = views.about(rf.get(manual_url))
about_url = urls.reverse('help:about')
response = views.about(rf.get(about_url))
assert _is_page(response)
for item in ('version', 'new_version', 'os_release'):
assert item in response.context_data

9
plinth/modules/help/views.py
View File

@ -10,17 +10,16 @@ import os
import pathlib
import apt
import requests
from django.core.files.base import File
from django.http import Http404, HttpResponse, HttpResponseRedirect
from django.template.response import TemplateResponse
from django.urls import reverse
from django.utils.translation import get_language_from_request
from django.utils.translation import gettext as _
import requests
from plinth import __version__, actions, cfg
from plinth.modules.upgrades.views import (get_os_release,
is_newer_version_available)
from plinth.modules.upgrades import views as upgrades_views
def index(request):
@ -96,8 +95,8 @@ def about(request):
context = {
'title': _('About {box_name}').format(box_name=_(cfg.box_name)),
'version': __version__,
'new_version': is_newer_version_available(),
'os_release': get_os_release()
'new_version': upgrades_views.is_newer_version_available(),
'os_release': upgrades_views.get_os_release()
}
return TemplateResponse(request, 'help_about.html', context)