nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-08-26 12:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

setup: Drop unused API for app's state management

Browse Source 
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2021-11-18 14:39:58 -08:00 committed by James Valleroy
parent b609abe7e5
commit 6f791d8806
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 0 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
plinth/setup.py
View File

@ -123,43 +123,6 @@ class Helper(object):
self.current_operation = {'step': step} self.current_operation = {'step': step}
return method(*args, **kwargs) return method(*args, **kwargs)
def get_state(self):
"""Return whether the module is not setup or needs upgrade."""
current_version = self.get_setup_version()
if current_version and self.module.version <= current_version:
return 'up-to-date'
# If a module need installing/updating but no setup method is
# available, then automatically set version.
#
# Minor violation of 'get' only discipline for convenience.
if not hasattr(self.module, 'setup'):
self.set_setup_version(self.module.version)
return 'up-to-date'
if not current_version:
return 'needs-setup'
return 'needs-update'
def get_setup_version(self):
"""Return the setup version of a module."""
# XXX: Optimize version gets
from . import models
try:
module_entry = models.Module.objects.get(pk=self.module_name)
return module_entry.setup_version
except models.Module.DoesNotExist:
return 0
def set_setup_version(self, version):
"""Set a module's setup version."""
from . import models
models.Module.objects.update_or_create(
pk=self.module_name, defaults={'setup_version': version})
def init(module_name, module): def init(module_name, module):
"""Create a setup helper for a module for later use.""" """Create a setup helper for a module for later use."""
@ -282,11 +245,6 @@ def _is_module_essential(module):
return getattr(module, 'is_essential', False) return getattr(module, 'is_essential', False)
def _module_state_matches(module, state):
"""Return if the current setup state of a module matches given state."""
return module.setup_helper.get_state() == state
def _set_is_first_setup(): def _set_is_first_setup():
"""Set whether all essential modules have been setup at least once.""" """Set whether all essential modules have been setup at least once."""
global _is_first_setup global _is_first_setup