From 72c1c7349fb88ef27f7c09d44eb85a91882f87c7 Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Mon, 28 Jan 2019 21:50:36 -0800
Subject: [PATCH] js: Remove javascript license link from footer

The link is hidden but not removed. librejs will still parse it. Ideally we
would want to do this from <link data-jslicense='1' href=''> but that seems to
cause problems for librejs.

Librejs users can still find out about the license of Javscript script file
using Librejs menu.

We already have a link to FreedomBox source code in the home page.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
---
 plinth/modules/jsxc/templates/jsxc_launch.html |  6 ++++++
 plinth/templates/base.html                     | 11 +++++------
 plinth/templates/index.html                    |  7 -------
 static/themes/default/css/plinth.css           | 10 ----------
 4 files changed, 11 insertions(+), 23 deletions(-)

diff --git a/plinth/modules/jsxc/templates/jsxc_launch.html b/plinth/modules/jsxc/templates/jsxc_launch.html
index 4a8195444..171cc38a6 100644
--- a/plinth/modules/jsxc/templates/jsxc_launch.html
+++ b/plinth/modules/jsxc/templates/jsxc_launch.html
@@ -134,6 +134,12 @@
         </div>
       </div>
     </div>
+
+    <div class="hidden">
+      <a href="{% static 'jslicense.html' %}" data-jslicense="1">
+        {% trans "JavaScript license information" %}</a>
+    </div>
+
   </body>
 
 </html>
diff --git a/plinth/templates/base.html b/plinth/templates/base.html
index 3c6e528bc..f1ca72cc2 100644
--- a/plinth/templates/base.html
+++ b/plinth/templates/base.html
@@ -246,14 +246,13 @@
   <footer>
     <div class="container">
       {% block footer_block %}
-        <div class="license-info">
-          <p>
-            <a href="{% static 'jslicense.html' %}" data-jslicense="1">
-              {% trans "JavaScript license information" %}</a>
-          </p>
-        </div>
       {% endblock %}
     </div>
+
+    <div class="hidden">
+      <a href="{% static 'jslicense.html' %}" data-jslicense="1">
+        {% trans "JavaScript license information" %}</a>
+    </div>
   </footer><!--/.footer-->
 </div><!--/#container-->
   {% block app_js %}<!-- placeholder for app-specific js files -->{% endblock %}
diff --git a/plinth/templates/index.html b/plinth/templates/index.html
index 906a4e5ce..f6882ac76 100644
--- a/plinth/templates/index.html
+++ b/plinth/templates/index.html
@@ -170,11 +170,4 @@
     </div>
   </div>
 
-  <div class="license-info">
-    <p>
-      <a href="{% static 'jslicense.html' %}" data-jslicense="1">
-        {% trans "JavaScript license information" %}</a>
-    </p>
-  </div>
-
 {% endblock %}
diff --git a/static/themes/default/css/plinth.css b/static/themes/default/css/plinth.css
index 4da0bcda6..65ce9bf66 100644
--- a/static/themes/default/css/plinth.css
+++ b/static/themes/default/css/plinth.css
@@ -161,12 +161,6 @@ body {
 
 /* Sticky footer styles
 -------------------------------------------------- */
-footer .license-info {
-    opacity: 0.5;
-    margin-right: 20px;
-    text-align: right;
-}
-
 .footer-logo {
     width: 140px;
 }
@@ -211,10 +205,6 @@ footer {
     padding-top: 150px;
 }
 
-footer license-info p {
-    margin: 20px 0;
-}
-
 .shortcut-label {
     min-height: 50px;
 }