utils: Simplify YAMLFile by removing the post_exit argument

Whatever function is passed in post_exit can simply be called by the caller
itself as the next statement.

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>

actions/matrixsynapse

@@ -31,7 +31,6 @@ from plinth import action_utils
 from plinth.modules import letsencrypt
 from plinth.modules.matrixsynapse import (CONFIG_FILE_PATH,
                                           get_configured_domain_name)
-from plinth.utils import YAMLFile
 
 
 def parse_arguments():

actions/tahoe-lafs

@@ -189,17 +189,19 @@ def subcommand_add_introducer(arguments):
 
     Param introducer must be a tuple of (pet_name, furl).
     """
-    with YAMLFile(introducers_file, restart_storage_node) as conf:
+    with YAMLFile(introducers_file) as conf:
         pet_name, furl = arguments.introducer.split(",")
         conf['introducers'][pet_name] = {'furl': furl}
+    restart_storage_node()
 
 
 def subcommand_remove_introducer(arguments):
     """Rename the introducer entry in the introducers.yaml file specified
     by the param pet_name
     """
-    with YAMLFile(introducers_file, restart_storage_node) as conf:
+    with YAMLFile(introducers_file) as conf:
         del conf['introducers'][arguments.pet_name]
+    restart_storage_node()
 
 
 def subcommand_get_introducers(_):

plinth/utils.py

@@ -89,16 +89,14 @@ def get_domain_names():
 class YAMLFile(object):
     """A context management class for updating YAML files"""
 
-    def __init__(self, yaml_file, post_exit=None):
+    def __init__(self, yaml_file):
         """Return a context object for the YAML file.
 
         Parameters:
         yaml_file - the YAML file to update.
-        post_exit - a function that will be called after
         updating the YAML file.
         """
         self.yaml_file = yaml_file
-        self.post_exit = post_exit
         self.conf = None
 
     def __enter__(self):
@@ -114,9 +112,6 @@ class YAMLFile(object):
         with open(self.yaml_file, 'w') as intro_conf:
             ruamel.yaml.round_trip_dump(self.conf, intro_conf)
 
-        if self.post_exit:
-            self.post_exit()
-
     def is_file_empty(self):
         return os.stat(self.yaml_file).st_size == 0