From 75a46962f054d4f5739f11ecc5751c2d1669f7bf Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa Date: Thu, 10 Sep 2020 16:57:08 -0700 Subject: [PATCH] module_loader, web_framework: Update console log messages - Drop message for initialization of each app. This was removed earlier but was reintroduced during init() refactoring. There is not much use for these messages and the noise they generate hide some important messages relating to domains added. - Print lists in a better way for humans. - Add a log message after all the initialization is completed. Signed-off-by: Sunil Mohan Adapa Reviewed-by: James Valleroy --- plinth/module_loader.py | 5 ++--- plinth/web_framework.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plinth/module_loader.py b/plinth/module_loader.py index a8c0621db..420c4a0e7 100644 --- a/plinth/module_loader.py +++ b/plinth/module_loader.py @@ -66,12 +66,13 @@ def load_modules(): except KeyError: logger.error('Unsatified dependency for module - %s', module_name) - logger.info('Module load order - %s', ordered_modules) + logger.info('Initializing apps - %s', ', '.join(ordered_modules)) for module_name in ordered_modules: _initialize_module(module_name, modules[module_name]) loaded_modules[module_name] = modules[module_name] + logger.debug('App initialization completed.') post_module_loading.send_robust(sender="module_loader") @@ -134,8 +135,6 @@ def _initialize_module(module_name, module): if module.setup_helper.get_state( ) != 'needs-setup' and module.app.is_enabled(): module.app.set_enabled(True) - - logger.debug("Initialized %s", module.__name__) except Exception as exception: logger.exception('Exception while running init for %s: %s', module, exception) diff --git a/plinth/web_framework.py b/plinth/web_framework.py index 481e2bbf5..22689c963 100644 --- a/plinth/web_framework.py +++ b/plinth/web_framework.py @@ -51,7 +51,7 @@ def init(read_only=False): django.setup(set_prefix=True) logger.debug('Configured Django with applications - %s', - settings.INSTALLED_APPS) + ', '.join(settings.INSTALLED_APPS)) def post_init():