From 75f5769c166c1637ba3dd5152946dcecb3fb9f61 Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Thu, 21 Oct 2021 19:26:26 -0400 Subject: [PATCH] quassel: Use BaseAppTests for functional tests Signed-off-by: James Valleroy Reviewed-by: Sunil Mohan Adapa --- .../modules/quassel/tests/test_functional.py | 37 ++++--------------- 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/plinth/modules/quassel/tests/test_functional.py b/plinth/modules/quassel/tests/test_functional.py index e24faa699..07752537a 100644 --- a/plinth/modules/quassel/tests/test_functional.py +++ b/plinth/modules/quassel/tests/test_functional.py @@ -4,37 +4,16 @@ Functional, browser based tests for quassel app. """ import pytest -from plinth.tests import functional + +from plinth.tests.functional import BaseAppTests pytestmark = [pytest.mark.apps, pytest.mark.quassel] -@pytest.fixture(scope='module', autouse=True) -def fixture_background(session_browser): - """Login and install the app.""" - functional.login(session_browser) - functional.install(session_browser, 'quassel') - yield - functional.app_disable(session_browser, 'quassel') +class TestQuasselApp(BaseAppTests): + app_name = 'quassel' + has_service = True + has_web = False - -def test_enable_disable(session_browser): - """Test enabling the app.""" - functional.app_disable(session_browser, 'quassel') - - functional.app_enable(session_browser, 'quassel') - assert functional.service_is_running(session_browser, 'quassel') - - functional.app_disable(session_browser, 'quassel') - assert functional.service_is_not_running(session_browser, 'quassel') - - -# TODO: Improve this to actually check that data configured servers is -# restored. -@pytest.mark.backups -def test_backup_restore(session_browser): - """Test backup and restore of app data.""" - functional.app_enable(session_browser, 'quassel') - functional.backup_create(session_browser, 'quassel', 'test_quassel') - functional.backup_restore(session_browser, 'quassel', 'test_quassel') - assert functional.service_is_running(session_browser, 'quassel') + # TODO: Improve test_backup_restore to actually check that data + # configured servers is restored.