nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-09-19 04:59:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

backups: Remove unnecessary context manager for paramiko SFTPClient

Browse Source 
Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
This commit is contained in:
Joseph Nuthalapati 2019-06-14 21:13:27 +05:30
parent 9f71c5867e
commit 795ed9d735
No known key found for this signature in database
GPG Key ID: 5398F00A2FA43C35
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plinth/modules/backups/views.py
View File

@ -410,7 +410,7 @@ def _validate_remote_repository(path, credentials, uuid=None):
password = credentials['ssh_password'] password = credentials['ssh_password']
repository = None repository = None
with _ssh_connection(hostname, username, password) as ssh_client: with _ssh_connection(hostname, username, password) as ssh_client:
with _sftp_client(ssh_client) as sftp_client: with ssh_client.open_sftp() as sftp_client:
dir_contents = None dir_contents = None
try: try:
dir_contents = sftp_client.listdir(dir_path) dir_contents = sftp_client.listdir(dir_path)
@ -454,16 +454,6 @@ def _ssh_connection(hostname, username, password):
ssh_client.close() ssh_client.close()
@contextmanager
def _sftp_client(ssh_client):
"""Context manager to create and close an SFTP client."""
sftp_client = ssh_client.open_sftp()
try:
yield sftp_client
finally:
sftp_client.close()
class RemoveRepositoryView(SuccessMessageMixin, TemplateView): class RemoveRepositoryView(SuccessMessageMixin, TemplateView):
"""View to delete a repository.""" """View to delete a repository."""
template_name = 'backups_repository_remove.html' template_name = 'backups_repository_remove.html'