snapshots: Fix for permissions issue when updating configuration

- Change `configure` command to `set-config` for consistency with `get-config`
- Run `set-config` as superuser

Fixes freedombox-team/plinth#1290

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>

actions/snapshot

@@ -47,7 +47,7 @@ def parse_arguments():
     subparser = subparsers.add_parser('delete-all',
                                       help='Delete all the snapshots')
 
-    subparser = subparsers.add_parser('configure',
+    subparser = subparsers.add_parser('set-config',
                                       help='Configure automatic snapshots')
     subparser.add_argument('config')
 
@@ -196,7 +196,7 @@ def _get_delete_arg(range_list):
         return range_list[0] + '-' + range_list[-1]
 
 
-def subcommand_configure(arguments):
+def subcommand_set_config(arguments):
     command = ['snapper', 'set-config', arguments.config]
     subprocess.run(command, check=True)
 

plinth/modules/snapshot/views.py

@@ -19,7 +19,6 @@ Views for snapshot module.
 """
 
 import json
-import subprocess
 
 from django.contrib import messages
 from django.shortcuts import redirect
@@ -109,10 +108,8 @@ def update_configuration(request, old_status, new_status):
                         ('number_min_age', 'NUMBER_MIN_AGE={}'),
                     ]))
 
-    command = ['snapper', 'set-config'] + list(config)
-
     try:
-        subprocess.run(command, check=True)
+        actions.superuser_run('snapshot', ['set-config', " ".join(config)])
 
         messages.success(request, _('Storage snapshots configuration updated'))
     except ActionError as exception: