nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-05-20 10:34:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

config: Send hostname change signal only after fully processing it

Browse Source 
If the domain name is not properly set before calling post_hostname_change
signal, then in the signal handlers config.get_domainname() returns an empty
string. So, call the post_hostname_change signal only after fully finishing the
hostname related changes, that is, after setting back the original domain name
too.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2019-08-20 09:21:47 -07:00 committed by James Valleroy
parent e8e2aaf85b
commit 855a99cc21
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plinth/modules/config/views.py
View File

@ -134,12 +134,12 @@ def set_hostname(hostname):
LOGGER.info('Changing hostname to - %s', hostname) LOGGER.info('Changing hostname to - %s', hostname)
actions.superuser_run('hostname-change', [hostname]) actions.superuser_run('hostname-change', [hostname])
post_hostname_change.send_robust(
sender='config', old_hostname=old_hostname, new_hostname=hostname)
LOGGER.info('Setting domain name after hostname change - %s', domainname) LOGGER.info('Setting domain name after hostname change - %s', domainname)
actions.superuser_run('domainname-change', [domainname]) actions.superuser_run('domainname-change', [domainname])
post_hostname_change.send_robust(
sender='config', old_hostname=old_hostname, new_hostname=hostname)
def set_domainname(domainname, old_domainname): def set_domainname(domainname, old_domainname):
"""Sets machine domain name to domainname""" """Sets machine domain name to domainname"""