nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

app: views: Expose method to get enabled/disabled state and cache it

Browse Source 
- So that it can be used by derived classes.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2024-03-07 18:03:35 -08:00 committed by James Valleroy
parent 0edb6a1219
commit 8f5dc14183
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
plinth/views.py
View File

@ -222,7 +222,7 @@ class AppView(FormView):
return super().get_form(*args, **kwargs)
def _get_common_status(self):
def get_common_status(self):
"""Return the status needed for form and template.
Avoid multiple queries to expensive operations such as
@ -238,7 +238,7 @@ class AppView(FormView):
def get_initial(self):
"""Return the status of the app to fill in the form."""
initial = super().get_initial()
initial.update(self._get_common_status())
initial.update(self.get_common_status())
return initial
def form_valid(self, form):
@ -257,9 +257,7 @@ class AppView(FormView):
if not self.app.can_be_disabled:
return None
initial = {
'should_enable': not self._get_common_status()['is_enabled']
}
initial = {'should_enable': not self.get_common_status()['is_enabled']}
return forms.AppEnableDisableForm(initial=initial)
def enable_disable_form_valid(self, form):
@ -276,7 +274,7 @@ class AppView(FormView):
def get_context_data(self, *args, **kwargs):
"""Add service to the context data."""
context = super().get_context_data(*args, **kwargs)
context.update(self._get_common_status())
context.update(self.get_common_status())
context['app_id'] = self.app.app_id
context['is_running'] = app_is_running(self.app)
context['app_info'] = self.app.info
@ -345,9 +343,8 @@ class SetupView(TemplateView):
context['setup_state'] = setup_state
context['operations'] = operation.manager.filter(app.app_id)
context['show_rerun_setup'] = False
context['show_uninstall'] = (
not app.info.is_essential
and setup_state != app_module.App.SetupState.NEEDS_SETUP)
context['show_uninstall'] = (not app.info.is_essential and setup_state
!= app_module.App.SetupState.NEEDS_SETUP)
# Perform expensive operation only if needed.
if not context['operations']: