From 959d1e255433eeed242082520d84f48737141187 Mon Sep 17 00:00:00 2001 From: Benedek Nagy Date: Fri, 12 Dec 2025 00:01:21 +0100 Subject: [PATCH] transmission: remove obsolete apache redirects Tests: - Install Transmission, apply the patch and confirm that the 409 conflict error, that the redirects were originally meant for, is not reproducible anymore. Fixes: #2502 Signed-off-by: Benedek Nagy Reviewed-by: Sunil Mohan Adapa --- plinth/modules/transmission/__init__.py | 4 ++-- .../apache2/conf-available/transmission-plinth.conf | 11 ----------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/plinth/modules/transmission/__init__.py b/plinth/modules/transmission/__init__.py index eee46cebd..92ef05598 100644 --- a/plinth/modules/transmission/__init__.py +++ b/plinth/modules/transmission/__init__.py @@ -58,7 +58,7 @@ class TransmissionApp(app_module.App): app_id = 'transmission' - _version = 7 + _version = 8 DAEMON = 'transmission-daemon' @@ -110,7 +110,7 @@ class TransmissionApp(app_module.App): webserver = Webserver('webserver-transmission', 'transmission-plinth', urls=['https://{host}/transmission'], - last_updated_version=6) + last_updated_version=8) self.add(webserver) daemon = Daemon( diff --git a/plinth/modules/transmission/data/usr/share/freedombox/etc/apache2/conf-available/transmission-plinth.conf b/plinth/modules/transmission/data/usr/share/freedombox/etc/apache2/conf-available/transmission-plinth.conf index b50c4be35..a1e98a55c 100644 --- a/plinth/modules/transmission/data/usr/share/freedombox/etc/apache2/conf-available/transmission-plinth.conf +++ b/plinth/modules/transmission/data/usr/share/freedombox/etc/apache2/conf-available/transmission-plinth.conf @@ -29,17 +29,6 @@ ## redirect URLs, set cookies, set absolute URLs (if any) ## properly. RequestHeader set X-Forwarded-Proto 'https' env=HTTPS - - # Make redirects to avoid 409 Conflict errors. See: #2219. Upstream issue: - # https://github.com/transmission/transmission/pull/857 . Drop this - # workaround with Transmission >= 4.0. - - RewriteEngine On - RewriteCond %{REQUEST_URI} ^/transmission/$ - RewriteRule .* /transmission/web/ [R=302,L] - RewriteCond %{REQUEST_URI} ^/transmission/web$ - RewriteRule .* /transmission/web/ [R=302,L] - # LDAP only authentication for Transmission remote UIs.