From 96318e5f94257f5f16de50e99a974fef3e3a5b90 Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa Date: Tue, 4 Apr 2023 10:08:01 +0530 Subject: [PATCH] coturn: Prevent package removal when roundcube is uninstalled Closes: #2328. Coturn depends on sqlite3 package. As sqlite3 is listed as a package in roundcube, it is removed when roundcube is uninstalled. This results in the removal of coturn as well. Prevent this by listing sqlite3 package explicitly in coturn app. Tests: - Without the patch, install coturn and roundcube. When roundcube is uninstalled, coturn package is no longer installed. - Apply the patch, install coturn and roundcube. When roundcube is uninstalled, coturn and sqlite3 packages are still installed. Signed-off-by: Sunil Mohan Adapa Reviewed-by: James Valleroy --- plinth/modules/coturn/__init__.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plinth/modules/coturn/__init__.py b/plinth/modules/coturn/__init__.py index a3c424191..d3b549d52 100644 --- a/plinth/modules/coturn/__init__.py +++ b/plinth/modules/coturn/__init__.py @@ -59,7 +59,9 @@ class CoturnApp(app_module.App): parent_url_name='apps') self.add(menu_item) - packages = Packages('packages-coturn', ['coturn']) + # Include sqlite3 to prevent removal of coturn from removal of + # roundcube. + packages = Packages('packages-coturn', ['coturn', 'sqlite3']) self.add(packages) firewall = Firewall('firewall-coturn', info.name,