mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-28 08:03:36 +00:00
samba: Fix Samba not accessible from IPv6 localhost ::1 address
Also: - Remove addressses [fc00::]/7 and [fe80::] from `allow hosts`, as those had no effect as described in #2334. - Remove unknown parameter `access control = yes` from Samba configuration. Tests performed in a stable container: - After Samba app upgrade was performed, enabled Samba Home share. - Using the `testparm` command, checked that the share is accessible from ::1 IPv6 address: ``` > sudo testparm -s /etc/samba/smb-freedombox.conf host-ip ::1 Allow connection from host-ip (::1) to disk_home > sudo testparm -s /etc/samba/smb-freedombox.conf host-ip ::2 Denied connection from host-ip (::2) Deny connection from host-ip (::2) to disk_home ``` - Checked that when `ping localhost` returns ::1 in the container, all the Samba tests pass. Closes #2334. Signed-off-by: Veiko Aasa <veiko17@disroot.org> Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
parent
601b48d5b1
commit
9bc07f60ed
@ -41,7 +41,7 @@ class SambaApp(app_module.App):
|
||||
|
||||
app_id = 'samba'
|
||||
|
||||
_version = 3
|
||||
_version = 4
|
||||
|
||||
def __init__(self) -> None:
|
||||
"""Create components for the app."""
|
||||
|
||||
@ -45,8 +45,7 @@ CONF = r'''
|
||||
# https://en.wikipedia.org/wiki/Private_network
|
||||
# https://en.wikipedia.org/wiki/Link-local_address
|
||||
# https://en.wikipedia.org/wiki/Unique_local_address
|
||||
access control = yes
|
||||
hosts allow = 127.0.0.0/8 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16 169.254.0.0/16 [::1] [fc00::]/7 [fe80::]
|
||||
hosts allow = 127.0.0.0/8 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16 169.254.0.0/16 ::1
|
||||
hosts deny = all
|
||||
''' # noqa: E501
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user