From 9cba16e0d033dfb3806d92997c6e502b5aed82e5 Mon Sep 17 00:00:00 2001
From: Michael Pimmer <info@fonfon.at>
Date: Wed, 14 Nov 2018 16:30:40 +0000
Subject: [PATCH] Backups: minor adaption of upload file size warning

Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
---
 plinth/modules/backups/templates/backups_upload.html |  8 +++++---
 plinth/modules/backups/views.py                      | 11 +++++++++--
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/plinth/modules/backups/templates/backups_upload.html b/plinth/modules/backups/templates/backups_upload.html
index 51a6a8efb..c82d108df 100644
--- a/plinth/modules/backups/templates/backups_upload.html
+++ b/plinth/modules/backups/templates/backups_upload.html
@@ -32,9 +32,11 @@
       You can choose the apps you wish to import after uploading a backup file.
     {% endblocktrans %}
   </p>
-  <div class="alert alert-info" role="alert">
-    {% trans "Free disk space" %}: {{ free_space }}<br />
-    {% trans "Make sure the uploaded file is smaller than that." %}
+  <div class="alert alert-warning" role="alert">
+    {% blocktrans trimmed %}
+      WARNING: You have {{ max_filesize }} available to restore a backup.<br />
+      Exceeding this limit can leave your {{ box_name }} unusable.
+    {% endblocktrans %}
   </div>
 
   <form class="form" enctype="multipart/form-data" method="post">
diff --git a/plinth/modules/backups/views.py b/plinth/modules/backups/views.py
index dae3f5fc7..29ddcd661 100644
--- a/plinth/modules/backups/views.py
+++ b/plinth/modules/backups/views.py
@@ -151,8 +151,15 @@ class UploadArchiveView(SuccessMessageMixin, FormView):
         except (PlinthError, PermissionError):
             logger.error('Error getting information about root partition.')
         else:
-            context['free_space'] = storage.format_bytes(
-                    disk_info["free_bytes"])
+            # The maximum file size that can be uploaded and restored is at
+            # most half of the available disk space:
+            # - Django stores uploaded files that do not fit into memory to
+            #   disk (/tmp/). These are only copied by form_valid() after
+            #   the upload is finished.
+            # - For restoring it's highly advisable to have at least as much
+            #   free disk space as the file size.
+            context['max_filesize'] = storage.format_bytes(
+                    disk_info["free_bytes"] / 2)
         return context
 
     def form_valid(self, form):