nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-04-15 09:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactored configuration action to avoid multiple start/stop calls of the action script when the configuration changes

Browse Source
This commit is contained in:
Daniel Steglich 2015-01-05 17:29:12 +00:00
parent 6b6e7f695f
commit 9fbe9754f6
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
plinth/modules/dynamicdns/dynamicdns.py
View File

@ -234,25 +234,24 @@ def _apply_changes(request, old_status, new_status):
old_status['dynamicdns_secret'] != \
new_status['dynamicdns_secret'] or \
old_status['dynamicdns_ipurl'] != \
new_status['dynamicdns_ipurl']:
new_status['dynamicdns_ipurl'] or \
old_status['enabled'] != \
new_status['enabled']:
_run(['configure', '-s', new_status['dynamicdns_server'],
'-d', new_status['dynamicdns_domain'],
'-u', new_status['dynamicdns_user'],
'-p', new_status['dynamicdns_secret'],
'-I', new_status['dynamicdns_ipurl']])
_run(['stop'])
_run(['start'])
messages.success(request,
_('Dynamic DNS configuration is updated!'))
if old_status['enabled'] != new_status['enabled']:
if old_status['enabled']:
_run(['stop'])
if new_status['enabled']:
_run(['start'])
messages.success(request, _('Dynamic DNS is enabled now!'))
else:
_run(['stop'])
messages.success(request, _('Dynamic DNS is disabled now!'))
messages.success(request,
_('Dynamic DNS configuration is updated!'))
else:
messages.error(request,
_('At least on failure occured,\