From a055209f54c1b7f6699e7a1da47b6e6e22053eb9 Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Wed, 20 Oct 2021 22:28:40 -0400 Subject: [PATCH] minidlna: Use BaseAppTests for functional tests Signed-off-by: James Valleroy Reviewed-by: Sunil Mohan Adapa --- .../modules/minidlna/tests/test_functional.py | 24 ++++--------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/plinth/modules/minidlna/tests/test_functional.py b/plinth/modules/minidlna/tests/test_functional.py index 26b49ca06..904864b3e 100644 --- a/plinth/modules/minidlna/tests/test_functional.py +++ b/plinth/modules/minidlna/tests/test_functional.py @@ -5,26 +5,12 @@ Functional, browser based tests for minidlna app. import pytest -from plinth.tests import functional +from plinth.tests.functional import BaseAppTests pytestmark = [pytest.mark.apps, pytest.mark.minidlna] -@pytest.fixture(scope='module', autouse=True) -def fixture_background(session_browser): - """Login and install the app.""" - functional.login(session_browser) - functional.install(session_browser, 'minidlna') - yield - functional.app_disable(session_browser, 'minidlna') - - -def test_enable_disable(session_browser): - """Test enabling the app.""" - functional.app_disable(session_browser, 'minidlna') - - functional.app_enable(session_browser, 'minidlna') - assert functional.service_is_running(session_browser, 'minidlna') - - functional.app_disable(session_browser, 'minidlna') - assert functional.service_is_not_running(session_browser, 'minidlna') +class TestMinidlnaApp(BaseAppTests): + app_name = 'minidlna' + has_service = True + has_web = False