From a615cbe24352b9b2ea6b1c6472aec5ab283f8578 Mon Sep 17 00:00:00 2001 From: Daniel Steglich Date: Wed, 4 Mar 2015 22:39:42 +0100 Subject: [PATCH] fixed form validation: at least dynamicdns_server or dynamicdns_update_url needs to be configured --- plinth/modules/dynamicdns/dynamicdns.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/plinth/modules/dynamicdns/dynamicdns.py b/plinth/modules/dynamicdns/dynamicdns.py index 6855722ad..e04ad36ea 100644 --- a/plinth/modules/dynamicdns/dynamicdns.py +++ b/plinth/modules/dynamicdns/dynamicdns.py @@ -166,8 +166,14 @@ class ConfigureForm(forms.Form): def clean(self): cleaned_data = super(ConfigureForm, self).clean() dynamicdns_secret = cleaned_data.get('dynamicdns_secret') + dynamicdns_update_url = cleaned_data.get('dynamicdns_update_url') + dynamicdns_server = cleaned_data.get('dynamicdns_server') old_dynamicdns_secret = self.initial['dynamicdns_secret'] + if not dynamicdns_update_url and not dynamicdns_server: + raise forms.ValidationError('please give update URL or \ + a GnuDIP Server') + if not dynamicdns_secret and not old_dynamicdns_secret: raise forms.ValidationError('please give a password')