From b372c2e2fa1ea08dac77e681a101777709d01eeb Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Fri, 5 Aug 2022 07:19:14 -0400 Subject: [PATCH] networks: Remove DNSSEC diagnostics - test.dnssec-or-not.net is no longer working. - If the test fails, it is not clear to the user what to do about it. Closes #1607, helps #1706. Signed-off-by: James Valleroy Reviewed-by: Veiko Aasa --- plinth/modules/networks/__init__.py | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/plinth/modules/networks/__init__.py b/plinth/modules/networks/__init__.py index 83c1d52f7..49744522b 100644 --- a/plinth/modules/networks/__init__.py +++ b/plinth/modules/networks/__init__.py @@ -6,7 +6,6 @@ FreedomBox app to interface with network-manager. import subprocess from logging import Logger -from django.utils.text import format_lazy from django.utils.translation import gettext_lazy as _ from plinth import actions @@ -79,9 +78,6 @@ class NetworksApp(app_module.App): results.append(daemon.diagnose_port_listening(53, 'tcp', address)) results.append(daemon.diagnose_port_listening(53, 'udp', address)) - results.append(_diagnose_dnssec('4')) - results.append(_diagnose_dnssec('6')) - return results @@ -156,28 +152,3 @@ def _get_interface_addresses(interfaces): addresses.append(parts[3].split('/')[0]) return addresses - - -def _diagnose_dnssec(kind='4'): - """Perform diagnostic on whether the system is using DNSSEC. - - Kind is either '4' or '6' for IPv4 and IPv6 respectively. - """ - kind_option = {'4': '-4', '6': '-6'}[kind] - - result = 'failed' - try: - output = subprocess.check_output([ - 'dig', kind_option, '+time=2', '+tries=1', - 'test.dnssec-or-not.net', 'TXT' - ]) - - if 'Yes, you are using DNSSEC' in output.decode(): - result = 'passed' - except subprocess.CalledProcessError: - pass - - template = _('Using DNSSEC on IPv{kind}') - testname = format_lazy(template, kind=kind) - - return [testname, result]