From b91d2d8c7fff44e4243e07bf715a1a30075cfa8f Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Mon, 6 Sep 2021 20:42:10 -0400 Subject: [PATCH] minidlna: Convert functional tests to non-BDD python format Signed-off-by: James Valleroy [sunil: Add markers] Signed-off-by: Sunil Mohan Adapa Reviewed-by: Sunil Mohan Adapa --- .../modules/minidlna/tests/minidlna.feature | 19 -------------- .../modules/minidlna/tests/test_functional.py | 25 +++++++++++++++++-- 2 files changed, 23 insertions(+), 21 deletions(-) delete mode 100644 plinth/modules/minidlna/tests/minidlna.feature diff --git a/plinth/modules/minidlna/tests/minidlna.feature b/plinth/modules/minidlna/tests/minidlna.feature deleted file mode 100644 index 22aa22308..000000000 --- a/plinth/modules/minidlna/tests/minidlna.feature +++ /dev/null @@ -1,19 +0,0 @@ -# SPDX-License-Identifier: AGPL-3.0-or-later - -@apps @minidlna -Feature: minidlna Simple Media Server - Run miniDLNA media server - -Background: - Given I'm a logged in user - And the minidlna application is installed - -Scenario: Enable minidlna application - Given the minidlna application is disabled - When I enable the minidlna application - Then the minidlna service should be running - -Scenario: Disable minidlna application - Given the minidlna application is enabled - When I disable the minidlna application - Then the minidlna service should not be running diff --git a/plinth/modules/minidlna/tests/test_functional.py b/plinth/modules/minidlna/tests/test_functional.py index 2b44dbc18..85d106ce9 100644 --- a/plinth/modules/minidlna/tests/test_functional.py +++ b/plinth/modules/minidlna/tests/test_functional.py @@ -3,6 +3,27 @@ Functional, browser based tests for minidlna app. """ -from pytest_bdd import scenarios +import pytest +from plinth.tests import functional -scenarios('minidlna.feature') +pytestmark = [pytest.mark.apps, pytest.mark.minidlna] + + +@pytest.fixture(scope='module', autouse=True) +def fixture_background(session_browser): + """Login and install the app.""" + functional.login(session_browser) + functional.install(session_browser, 'minidlna') + yield + functional.app_disable(session_browser, 'minidlna') + + +def test_enable_disable(session_browser): + """Test enabling the app.""" + functional.app_disable(session_browser, 'minidlna') + + functional.app_enable(session_browser, 'minidlna') + assert functional.service_is_running(session_browser, 'minidlna') + + functional.app_disable(session_browser, 'minidlna') + assert functional.service_is_not_running(session_browser, 'minidlna')