From bb544b0a6dba08161d1fd2fda4f745143d522234 Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Sun, 12 Feb 2023 14:28:43 -0500 Subject: [PATCH] dynamicdns: Skip uninstall test Tests: - test_uninstall is skipped for dynamicdns. - test_uninstall is passed for bepasty. Signed-off-by: James Valleroy Reviewed-by: Sunil Mohan Adapa --- plinth/modules/dynamicdns/tests/test_functional.py | 1 + plinth/tests/functional/__init__.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/plinth/modules/dynamicdns/tests/test_functional.py b/plinth/modules/dynamicdns/tests/test_functional.py index 4f6af00a2..5643734af 100644 --- a/plinth/modules/dynamicdns/tests/test_functional.py +++ b/plinth/modules/dynamicdns/tests/test_functional.py @@ -75,6 +75,7 @@ class TestDynamicDNSApp(functional.BaseAppTests): app_name = 'dynamicdns' has_service = False has_web = False + can_uninstall = False check_diagnostics = False @staticmethod diff --git a/plinth/tests/functional/__init__.py b/plinth/tests/functional/__init__.py index 002132d26..ecf939dfe 100644 --- a/plinth/tests/functional/__init__.py +++ b/plinth/tests/functional/__init__.py @@ -641,6 +641,7 @@ class BaseAppTests: # TODO: Check the components of the app instead of configuring here. has_service = False has_web = True + can_uninstall = True check_diagnostics = True diagnostics_delay = 0 disable_after_tests = True @@ -706,6 +707,9 @@ class BaseAppTests: def test_uninstall(self, session_browser): """Test that app can be uninstalled and installed back again.""" + if not self.can_uninstall: + pytest.skip(f'Skipping uninstall test for {self.app_name}.') + uninstall(session_browser, self.app_name) assert not is_installed(session_browser, self.app_name) install(session_browser, self.app_name)