nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-08-26 12:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix backups API test cases to work under all conditions

Browse Source 
Ensure that loaded module list is mocked instead of actually loading modules.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2019-03-05 11:20:37 -08:00 committed by James Valleroy
parent 0e2315486d
commit bbb80fe577
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plinth/modules/backups/tests/test_api.py
View File

@ -111,8 +111,10 @@ class TestBackupProcesses(unittest.TestCase):
@staticmethod @staticmethod
@patch('plinth.modules.backups.api._install_apps_before_restore') @patch('plinth.modules.backups.api._install_apps_before_restore')
def test_restore_apps(mock_install): @patch('plinth.module_loader.loaded_modules.items')
def test_restore_apps(mock_install, modules):
"""Test that restore_handler is called.""" """Test that restore_handler is called."""
modules.return_value = [('a', MagicMock())]
restore_handler = MagicMock() restore_handler = MagicMock()
api.restore_apps(restore_handler) api.restore_apps(restore_handler)
restore_handler.assert_called_once() restore_handler.assert_called_once()
@ -129,7 +131,6 @@ class TestBackupProcesses(unittest.TestCase):
del apps[3][1].backup del apps[3][1].backup
modules.return_value = apps modules.return_value = apps
module_loader.load_modules()
returned_apps = api.get_all_apps_for_backup() returned_apps = api.get_all_apps_for_backup()
expected_apps = [ expected_apps = [
api.BackupApp('a', apps[0][1]), api.BackupApp('a', apps[0][1]),
@ -148,7 +149,6 @@ class TestBackupProcesses(unittest.TestCase):
] ]
modules.return_value = apps modules.return_value = apps
module_loader.load_modules()
app_names = ['config', 'names'] app_names = ['config', 'names']
apps = api.get_apps_in_order(app_names) apps = api.get_apps_in_order(app_names)
assert apps[0].name == 'names' assert apps[0].name == 'names'