From bdd078a406e365d011810a4cec60c99865a96671 Mon Sep 17 00:00:00 2001 From: James Valleroy Date: Tue, 23 Mar 2021 10:52:26 -0400 Subject: [PATCH] dynamicdns: Wait after changing domain name in tests After a domain name change, Let's Encrypt will restart the webserver and could cause a connection failure. Test: DynamicDNS functional tests are passing. Signed-off-by: James Valleroy Reviewed-by: Veiko Aasa --- plinth/modules/dynamicdns/tests/test_functional.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/plinth/modules/dynamicdns/tests/test_functional.py b/plinth/modules/dynamicdns/tests/test_functional.py index 276c487e6..a9437558a 100644 --- a/plinth/modules/dynamicdns/tests/test_functional.py +++ b/plinth/modules/dynamicdns/tests/test_functional.py @@ -39,6 +39,10 @@ def _configure(browser): 'http://myip.datasystems24.de') functional.submit(browser) + # After a domain name change, Let's Encrypt will restart the web + # server and could cause a connection failure. + functional.eventually(functional.nav_to_module, [browser, 'dynamicdns']) + def _has_original_config(browser): functional.nav_to_module(browser, 'dynamicdns') @@ -71,3 +75,7 @@ def _change_config(browser): browser.find_by_id('id_dynamicdns_ipurl').fill( 'http://myip2.datasystems24.de') functional.submit(browser) + + # After a domain name change, Let's Encrypt will restart the web + # server and could cause a connection failure. + functional.eventually(functional.nav_to_module, [browser, 'dynamicdns'])