nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

syncthing: Open firewall ports for listening and discovery

Browse Source 
- Closes #1592.

- Use firewall service definition 'syncthing' already available.

- Open externally also, helps in syncing with peers on the Internet. Open
  discovery port also externally and syncthing deal with the traffic.

- Based on https://docs.syncthing.net/users/firewall.html

Test:

- Install version 2, syncthing firewall service is enabled in internal and
  external zones.

- Disable app, syncthing firewall service is removed. Enable app, syncthing
  firewall service is added.

- Install version 1, upgrade to version 2, syncthing firewall service is added.

- Install version 1, disable syncthing, upgrade to version 2, syncthing firewall
  service is not added. Enable syncthing, firewall service is added.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2019-06-24 11:23:42 -07:00 committed by James Valleroy
parent 1867cc6e50
commit c6bbc847b4
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
plinth/modules/syncthing/__init__.py
View File

@ -31,7 +31,7 @@ from plinth.utils import format_lazy
from .manifest import backup, clients
version = 1
version = 2
managed_services = ['syncthing@syncthing']
@ -87,10 +87,14 @@ class SyncthingApp(app_module.App):
login_required=True, allowed_groups=[group[0]])
self.add(shortcut)
firewall = Firewall('firewall-syncthing', name,
firewall = Firewall('firewall-syncthing-web', name,
ports=['http', 'https'], is_external=True)
self.add(firewall)
firewall = Firewall('firewall-syncthing-ports', name,
ports=['syncthing'], is_external=True)
self.add(firewall)
webserver = Webserver('webserver-syncthing', 'syncthing-plinth')
self.add(webserver)
@ -113,7 +117,11 @@ def setup(helper, old_version=None):
"""Install and configure the module."""
helper.install(managed_packages)
helper.call('post', actions.superuser_run, 'syncthing', ['setup'])
helper.call('post', app.enable)
if not old_version:
helper.call('post', app.enable)
if old_version == 1 and app.is_enabled():
app.get_component('firewall-syncthing-ports').enable()
def diagnose():