nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: operation: Fix mock has_calls assertion

Browse Source 
In Python 3.12, has_calls is not a valid assertion.

Closes: #1058421

Tests:

- Run "python3.12 -m pytest plinth/tests/test_operation.py" in unstable
  container. All tests are passed.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
James Valleroy 2023-12-16 09:32:05 -05:00 committed by Sunil Mohan Adapa
parent 4b9f7c86a7
commit c8dac10308
No known key found for this signature in database
GPG Key ID: 43EA1CFF0AA7C5F2
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plinth/tests/test_operation.py
View File

@ -45,7 +45,7 @@ def test_operation_default_initialization(update_notification):
assert operation.thread_data == {}
assert isinstance(operation.thread, threading.Thread)
assert operation.thread._operation == operation
assert update_notification.has_calls([call()])
update_notification.assert_has_calls([call()])
@patch('plinth.operation.Operation._update_notification')
@ -64,7 +64,7 @@ def test_operation_initialization(update_notification):
assert operation._message is None
assert operation.exception is None
assert operation.thread_data == {'data1': 'datavalue1'}
assert update_notification.has_calls([call()])
update_notification.assert_has_calls([call()])
def test_operation_str():
@ -87,7 +87,7 @@ def test_successful_operation(update_notification):
assert operation.state == Operation.State.COMPLETED
assert operation.return_value == 'test-return'
on_complete.assert_has_calls([call(operation)])
assert update_notification.has_calls([call(), call()])
update_notification.assert_has_calls([call(), call()])
@patch('plinth.operation.Operation._update_notification')
@ -106,7 +106,7 @@ def test_error_operation(update_notification):
assert operation.state == Operation.State.COMPLETED
assert operation.exception == target.side_effect
on_complete.assert_has_calls([call(operation)])
assert update_notification.has_calls([call(), call()])
update_notification.assert_has_calls([call(), call()])
@patch('plinth.operation.Operation._update_notification')
@ -173,7 +173,7 @@ def test_updating_operation(update_notification):
assert operation._message == 'message1'
assert operation.exception == exception
assert update_notification.has_calls([call(), call(), call()])
update_notification.assert_has_calls([call(), call(), call()])
@patch('plinth.app.App.get')