nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-03-11 09:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

diagnose: Move negating diagnose result inside try bock

Browse Source 
A caught Exception should always be considered a failed test.

Signed-off-by: Matthias Dellweg <2500@gmx.de>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
Matthias Dellweg 2019-09-22 10:40:24 +00:00 committed by Sunil Mohan Adapa
parent aca0c65d68
commit cb3e050722
No known key found for this signature in database
GPG Key ID: 43EA1CFF0AA7C5F2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plinth/action_utils.py
View File

@ -423,12 +423,14 @@ def diagnose_netcat(host, port, input='', negate=False):
result = 'failed'
else:
result = 'passed'
if negate:
result = 'failed' if result == 'passed' else 'passed'
except Exception:
result = 'failed'
test = _('Connect to {host}:{port}')
if negate:
result = 'failed' if result == 'passed' else 'passed'
test = _('Cannot connect to {host}:{port}')
return [test.format(host=host, port=port), result]