From d7b05385c6cae3f76675f39cb5d240c4725588aa Mon Sep 17 00:00:00 2001 From: Sunil Mohan Adapa Date: Fri, 5 Apr 2024 16:23:03 -0700 Subject: [PATCH] nextcloud: Use secrets module generate passwords - It choose highest security random number automatically. Signed-off-by: Sunil Mohan Adapa Reviewed-by: James Valleroy --- plinth/modules/nextcloud/privileged.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plinth/modules/nextcloud/privileged.py b/plinth/modules/nextcloud/privileged.py index 4a9468a57..38d793ec0 100644 --- a/plinth/modules/nextcloud/privileged.py +++ b/plinth/modules/nextcloud/privileged.py @@ -3,7 +3,7 @@ import json import pathlib -import random +import secrets import shutil import string import subprocess @@ -304,8 +304,7 @@ def _drop_database(): def _generate_secret_key(length=64, chars=None): """Generate a new random secret key for use with Nextcloud.""" chars = chars or (string.ascii_letters + string.digits) - rand = random.SystemRandom() - return ''.join(rand.choice(chars) for _ in range(length)) + return ''.join(secrets.choice(chars) for _ in range(length)) def _set_maintenance_mode(on: bool):