Suppress unnecessary logging in cfg tests

Signed-off-by: Joseph Nuthalapati <njoseph@thoughtworks.com>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Joseph Nuthalapati 2017-11-24 11:28:11 +05:30 committed by James Valleroy
parent 8da56c0fb4
commit dafd2f113e
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808

View File

@ -14,18 +14,17 @@
# You should have received a copy of the GNU Affero General Public License # You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
# #
""" """
Test module for configuration module. Test module for configuration module.
""" """
import configparser import configparser
import logging
import os import os
import unittest import unittest
from plinth import cfg from plinth import cfg
TEST_CONFIG_DIR = \ TEST_CONFIG_DIR = \
os.path.join(os.path.dirname(os.path.realpath(__file__)), 'data') os.path.join(os.path.dirname(os.path.realpath(__file__)), 'data')
CONFIG_FILE_WITH_MISSING_OPTIONS = \ CONFIG_FILE_WITH_MISSING_OPTIONS = \
@ -33,9 +32,12 @@ CONFIG_FILE_WITH_MISSING_OPTIONS = \
CONFIG_FILE_WITH_MISSING_SECTIONS = \ CONFIG_FILE_WITH_MISSING_SECTIONS = \
os.path.join(TEST_CONFIG_DIR, 'plinth.config.with_missing_sections') os.path.join(TEST_CONFIG_DIR, 'plinth.config.with_missing_sections')
logging.disable(logging.CRITICAL)
class TestCfg(unittest.TestCase): class TestCfg(unittest.TestCase):
"""Verify that the Plinth configuration module behaves as expected.""" """Verify that the Plinth configuration module behaves as expected."""
@classmethod @classmethod
def setUpClass(cls): def setUpClass(cls):
"""Locate and copy the official plinth.config file.""" """Locate and copy the official plinth.config file."""
@ -104,15 +106,15 @@ class TestCfg(unittest.TestCase):
def test_read_config_file_with_missing_sections(self): def test_read_config_file_with_missing_sections(self):
"""Verify that missing configuration sections can be detected.""" """Verify that missing configuration sections can be detected."""
self.assertRaises( self.assertRaises(configparser.NoSectionError, cfg.read,
configparser.NoSectionError, cfg.read, CONFIG_FILE_WITH_MISSING_SECTIONS,
CONFIG_FILE_WITH_MISSING_SECTIONS, self.test_config_dir) self.test_config_dir)
def test_read_config_file_with_missing_options(self): def test_read_config_file_with_missing_options(self):
"""Verify that missing configuration options can be detected.""" """Verify that missing configuration options can be detected."""
self.assertRaises( self.assertRaises(configparser.NoOptionError, cfg.read,
configparser.NoOptionError, cfg.read, CONFIG_FILE_WITH_MISSING_OPTIONS,
CONFIG_FILE_WITH_MISSING_OPTIONS, self.test_config_dir) self.test_config_dir)
def compare_configurations(self, parser): def compare_configurations(self, parser):
"""Compare two sets of configuration values.""" """Compare two sets of configuration values."""
@ -124,23 +126,24 @@ class TestCfg(unittest.TestCase):
self.assertEqual(parser.get('Path', 'config_dir'), cfg.config_dir) self.assertEqual(parser.get('Path', 'config_dir'), cfg.config_dir)
self.assertEqual(parser.get('Path', 'data_dir'), cfg.data_dir) self.assertEqual(parser.get('Path', 'data_dir'), cfg.data_dir)
self.assertEqual(parser.get('Path', 'store_file'), cfg.store_file) self.assertEqual(parser.get('Path', 'store_file'), cfg.store_file)
self.assertEqual(parser.get('Path', 'actions_dir'), self.assertEqual(parser.get('Path', 'actions_dir'), cfg.actions_dir)
cfg.actions_dir)
self.assertEqual(parser.get('Path', 'doc_dir'), cfg.doc_dir) self.assertEqual(parser.get('Path', 'doc_dir'), cfg.doc_dir)
self.assertEqual(parser.get('Path', 'status_log_file'), self.assertEqual(
cfg.status_log_file) parser.get('Path', 'status_log_file'), cfg.status_log_file)
self.assertEqual(parser.get('Path', 'access_log_file'), self.assertEqual(
cfg.access_log_file) parser.get('Path', 'access_log_file'), cfg.access_log_file)
self.assertEqual(5, len(parser.items('Network'))) self.assertEqual(5, len(parser.items('Network')))
self.assertEqual(parser.get('Network', 'host'), cfg.host) self.assertEqual(parser.get('Network', 'host'), cfg.host)
self.assertEqual(int(parser.get('Network', 'port')), cfg.port) self.assertEqual(int(parser.get('Network', 'port')), cfg.port)
self.assertEqual(parser.get('Network', 'secure_proxy_ssl_header'), self.assertEqual(
cfg.secure_proxy_ssl_header) parser.get('Network', 'secure_proxy_ssl_header'),
cfg.secure_proxy_ssl_header)
self.assertIsInstance(cfg.use_x_forwarded_host, bool) self.assertIsInstance(cfg.use_x_forwarded_host, bool)
self.assertEqual(parser.get('Network', 'use_x_forwarded_host'), self.assertEqual(
str(cfg.use_x_forwarded_host)) parser.get('Network', 'use_x_forwarded_host'),
str(cfg.use_x_forwarded_host))
self.assertEqual(3, len(parser.items('Misc'))) self.assertEqual(3, len(parser.items('Misc')))
self.assertEqual(parser.get('Misc', 'danube_edition'), self.assertEqual(
str(cfg.danube_edition)) parser.get('Misc', 'danube_edition'), str(cfg.danube_edition))
self.assertEqual(parser.get('Misc', 'box_name'), cfg.box_name) self.assertEqual(parser.get('Misc', 'box_name'), cfg.box_name)